Closed tlvu closed 2 years ago
The test failure seems relevant. The question is whether the test is wrong, or the code is wrong.
The test failure seems relevant. The question is whether the test is wrong, or the code is wrong.
FYI I was following this existing test: https://github.com/computationalmodelling/nbval/blob/1397af8a82dc3966db8ba6a706cbf2f0e32db152/tests/test_ignore.py#L12-L14
The test failure seems relevant. The question is whether the test is wrong, or the code is wrong.
FYI I was following this existing test:
@vidartf I have a feeling the collector
object matches each dir/file level in the file path. We just had another AttributeError: 'Session' object has no attribute 'skip_compare'
simply because our parent dir also ends with .ipynb
, see our recent commit https://github.com/Ouranosinc/PAVICS-e2e-workflow-tests/pull/82/commits/da918ecb843fdb0fc09191610a231557271fde77
Is that the expected behavior of the collector
object?
Those test failures are quite similar to the matplotlib one discussed in https://github.com/computationalmodelling/nbval/issues/167. There is also a workaround in that issue.
Those test failures are quite similar to the matplotlib one discussed in #167. There is also a workaround in that issue.
Not sure how this is related. The workaround above it to ignore a deprecation warning. This error is about how to properly configure nbval to skip compare certain cell type. There are other cell type than stderr
, like text/html
so the deprecation warning ignore will not work.
Well, I was responding an earlier comment:
The test failure seems relevant.
From what I understand, the test failure is irrelevant to this change. Instead, it is because the deprecation warning is printed to stderr, so there are Unexpected output fields from running code: {'stderr'}
, as shown in this log: https://travis-ci.org/github/computationalmodelling/nbval/jobs/771723312. Ignoring deprecation warnings should make tests pass.
Thanks!
Fixes https://github.com/computationalmodelling/nbval/issues/168
Without this fix we have the following error: