computationalmystic / augur-group25

MIT License
1 stars 2 forks source link

Date display not correctly (Update) #2

Closed Qisheng-Tang closed 5 years ago

Qisheng-Tang commented 5 years ago

Is your feature request related to a problem? If so, please describe the problem: Two statistic graph in our software do not show correct end date.

To Reproduce

  1. Go to ' ec2-18-217-244-45.us-east-2.compute.amazonaws.com:3333'
  2. Click on 'github.com/twitter/twemoji'
  3. Click on 'Experimental'
  4. Scroll down to 'Line changed/Month' and 'Commits/week'
  5. The End date shows Dec 31, 1969 (See bug)

Expected Behavior The end date should be when the repository update recently.

Screenshots 屏幕快照 2019-04-28 下午6 23 48 屏幕快照 2019-04-28 下午6 23 56

Desktop (please complete the following information): -OS: Mac OS 10.14.4 -Browser: Safari

Describe the solution you'd like: A clear and concise description of what you want to happen. We hope to fix this bug so that the date can be shown in a regular year

Solution We will try to modify our code to solve this problem. We will try to modify 'DynamicLineChart.vue'

Qisheng-Tang commented 5 years ago

This issue may be the most difficult one. We will figure out other issues first.

Arianardo commented 5 years ago

We just fixed this on lines changed per week and month graphs so now they display the correct end date. Still working on commits per week graph as it is now blank after these changes.

Arianardo commented 5 years ago

Commits per week is up but not displaying correctly.

Arianardo commented 5 years ago

All graphs are up and display the date correctly.

ghost commented 5 years ago

In order to fix the issue we needed to add a function to reformat the date variable so that it can be accepted by Vega Lite. This is the solution we came up with:

Screen Shot 2019-05-04 at 7 47 54 PM
ghost commented 5 years ago

This issue was assigned too and worked on by all three group members. Gabe sat down with us and walked us through how this function should we implemented, and then we all worked together to get it to work.

ghost commented 5 years ago

This is how the new date is formatted in the API Endpoint for "commits per week". The other endpoints now format their data very similar to this.

Screen Shot 2019-05-05 at 3 21 33 PM