computationalmystic / augur-group25

MIT License
1 stars 2 forks source link

Update "Commits per Week" SQL #8

Closed ghost closed 5 years ago

ghost commented 5 years ago

Describe the bug: The SQL does not retrieve the date of commit in the correct format so the Vega Lite graphs will have trouble displaying it.

To Reproduce: Steps to reproduce the behavior:

  1. Go to ec2-18-217-244-45.us-east-2.compute.amazonaws.com:3333
  2. Click on the 'experimental' card
  3. Scroll down to 'Commits/Week'
  4. See the graph not displaying the data correctly.

Expected behavior: You should notice that the graph displays 1961 as the date and no lines being shown on the graph. This is due to the date not being formatted correctly so no information will show up.

Screenshots

Screen Shot 2019-05-03 at 3 23 25 PM

Desktop (please complete the following information):

Additional context We worked on this issue in office hours. We need to concatenate the date so that Vega Lite accepts it.

This was assigned to Matt Rockey

ghost commented 5 years ago

For this issue we noticed that the "commits per week" SQL was given incorrect parameters, and that the SQL was not returning a "date" variable. This would prevent the graph from displaying the data with the correct timeframe and break it. Our solution was to change the SQL so it selected "author_date" and returned that so it could be used by our graphs.

Screen Shot 2019-05-03 at 3 08 21 PM
ghost commented 5 years ago

This issue is complete so we closed the issue.

ghost commented 5 years ago

Now, author_date is selected from the facade database. This is how the endpoints displays the new data:

Screen Shot 2019-05-05 at 3 21 33 PM