computerjazz / react-native-infinite-pager

An infinitely-swipeable pager component.
MIT License
175 stars 16 forks source link

Flickering effect when swiping #32

Open MarcLopezAvila opened 3 months ago

MarcLopezAvila commented 3 months ago

There is a a logic to cause a page change when swiping beyond the middle of the current screen and when that happens there is a flickering effect I understand caused because the internal array of items and buffer are updated. Is there any solution to that? I tried many confugurations but couldn't solve this. It happens also with the most basic example provided. You can notice the flickering while the numbers are updated.

Not sure how the solution should look like but probably, some logic could be done at the end of the swipe to avoid doing it while the user is swiping, causing the flickering effect due to those internal state updates.

Any help would be very appreciated, thanks!

terreng commented 3 months ago

As far as I can tell this only happens on Android, I haven't seen it on iOS or on the web.

Here's a video that shows the flickering when passing over the halfway point.

The flickering might not be visible when watching this video on a 60 Hz screen, because the screen recording is 90fps. Watch the video at 0.5x speed to see it.

https://github.com/user-attachments/assets/2291b093-dd08-4453-8020-f32e6825f883

Here's a still frame from one of the flickers, showing that the left page becomes misaligned briefly.

pehkay commented 3 months ago

I noticed this effect too.

MarcLopezAvila commented 3 months ago

Does anyone have a solution to it?

computerjazz commented 3 months ago

What version of reanimated are you on? There are known performance issues starting in 3.9.0 that have recently been addressed: https://github.com/software-mansion/react-native-reanimated/issues/6247#issuecomment-2235977637

https://github.com/software-mansion/react-native-reanimated/pull/6218

MarcLopezAvila commented 3 months ago

Hi! Thank you for your quick response @computerjazz , I am using "react-native-reanimated": "3.10.1" which is the one bundled for the latest Expo version 51. I tried to use a different one, either superior or inferior to 3.9.0 but it is not possible since it is bundled with Expo.

I ended up creating a development build with the latest version of reanimated, 3.15.0 and the fickering persists

peterjskaltsis commented 2 months ago

@MarcLopezAvila are you using initialIndex / onPageChange props by any chance?

MarcLopezAvila commented 2 months ago

I am not using initialIndex but I do use onPageChange. My thoughts are that it is because onPageChange is triggered while the user is swiping and not at the end of the swipe so the setStates or anything triggered by the onPageChange is causing some rerender bottleneck and that causes the flickering. I would say that is a common usage anyway.

pehkay commented 2 months ago

Maybe check if the setState is setting undesired value e.g undefined?

terreng commented 2 months ago

I am not using onPageChange, but the flickering still happens.

audrius-savickas commented 2 months ago

does anyone have a solution? I'm not using neither onPageChange, nor initialIndex, but issue still happens. I tried upgrading Reanimated from 3.11.0 to 3.15.1, but no difference as far as I can tell - FPS drops heavily between the pages transition and there is a gap between slides. I'm able to get the FPS down from 60 to 30 by constantly swiping near the transition mark.