search

computerline1z / okapi

Automatically exported from code.google.com/p/okapi
0 stars 0 forks source link

Wrong attribute in TMX filter getTypeAttribute() method #345

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The TMX filter method getTypeAttribute() is looking for a "lang" attribute, 
instead of "type".

I didn't fix the issue because this seems to cause some test error in the 
round-trip test cases.

I've also added a getAttribute(String localName) that we can probably share now 
that several attributes are looked up. BTW: it looks like an expensive way to 
read an attribute. Maybe that can be optimized.

Original issue reported on code.google.com by yves.sav...@gmail.com on 27 Jun 2013 at 5:31

GoogleCodeExporter commented 9 years ago 
Wow, thanks for catching that. What's worse is that the attributes on the <hi> 
elements were stripped out. The round-trip comparison didn't catch that. Seems 
it compares the type of the code but not the rawText.

Original comment by fli...@enlaso.com on 27 Jun 2013 at 7:19

GoogleCodeExporter commented 9 years ago

Original comment by fli...@enlaso.com on 27 Jun 2013 at 7:22