search

computerline1z / okapi

Automatically exported from code.google.com/p/okapi
0 stars 0 forks source link

Cannot register an inner class as IEditorDescriptionProvider #347

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
I tried to register a static inner class as an IEditorDescriptionProvider for 
my IParameters class (using EditorFor).  It didn't work.  The problem is, the 
class is registered with the IParametersEditorMapper under its class name 
(Class.getName(), returned by FilterConfigurationMapper.addConfigurations), but 
retrieved under its canonical class name (Class.getCanonicalName(), in 
FilterConfigurationEditor.editConfiguration).  For inner classes, these is not 
the same.

I can't think of any reason for using getCanonicalName, so I suggest changing 
it to getName.  I will attach a patch against dev.

Original issue reported on code.google.com by and...@spartansoftwareinc.com on 28 Jun 2013 at 9:15

GoogleCodeExporter commented 9 years ago 
Patch attached.  With this change, my IEditorDescriptionProvider works as 
expected.

Original comment by and...@spartansoftwareinc.com on 28 Jun 2013 at 9:18

GoogleCodeExporter commented 9 years ago 
Where did you put the path Andrew? I don't see it.
Thanks.

Original comment by yves.sav...@gmail.com on 29 Jun 2013 at 4:04

GoogleCodeExporter commented 9 years ago 
Try again!

Original comment by and...@spartansoftwareinc.com on 29 Jun 2013 at 6:14

Attachments:

GoogleCodeExporter commented 9 years ago 
Done. I'll push it once all tests are done.
Thanks.

Original comment by yves.sav...@gmail.com on 29 Jun 2013 at 6:33

GoogleCodeExporter commented 9 years ago 
This issue was closed by revision fe12af5444f5.

Original comment by yves.sav...@gmail.com on 29 Jun 2013 at 6:44