search

computerline1z / okapi

Automatically exported from code.google.com/p/okapi
0 stars 0 forks source link

Expand Locale variables like ${trgLoc} in resourceParameters.dbDirectory of the PensieveTMConnector #429

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
Just enter the following text as name of tmx file in the settings of the 
leveraging step. In my case i use the PensieveTMConnector.

${rootDir}\${trgLang}.tmx

The line in the pipeline file looks like
resourceParameters.dbDirectory=${rootDir}\${trgLang}.tmx

What is the expected output? What do you see instead?
The ${trgLang} variable should be replaced by the real target locale

What version of the product are you using? On what operating system?

-------------------------------------------------------------------------------
Okapi Tikal - Localization Toolset
Version: 2.0.26
-------------------------------------------------------------------------------
Java version: 1.7.0_71
Platform: Windows 7, amd64, 6.1
Java VM memory: free=184.295 KB, total=187.904 KB
Tikal display encoding: cp850
-------------------------------------------------------------------------------
Please provide any additional information below.

Original issue reported on code.google.com by Uli.Laeg...@gmail.com on 18 Dec 2014 at 10:01

GoogleCodeExporter commented 9 years ago 
The issue is that the dbDirectory of the PensieveTMConnector is processed for 
rootDir but not for locales variables.
The documentation doesn't state any variable can be used.
The fix is to add the code in the connector and update the documentation.

Original comment by yves.sav...@gmail.com on 18 Dec 2014 at 12:24

GoogleCodeExporter commented 9 years ago 
I've updated the connector's code.
The fix is available here:
http://okapi.opentag.com/snapshots/okapi-apps_win32-x86_64_0.27-SNAPSHOT.zip

Could you verify if it works now and report back so we can close the issue?
Thanks.
-ys

Original comment by yves.sav...@gmail.com on 18 Dec 2014 at 12:44

GoogleCodeExporter commented 9 years ago 
Hi Yves,

the variable is replaced now but the value is blank.
Note that i call this step in a pipeline which i invoke from the command line.
I set the -sl de -tl en parameters on the command line

Original comment by Uli.Laeg...@gmail.com on 18 Dec 2014 at 3:00

GoogleCodeExporter commented 9 years ago 
Thanks for the quick feedback.
I guess i'll have to debug to see what is happening.

Original comment by yves.sav...@gmail.com on 18 Dec 2014 at 3:10

GoogleCodeExporter commented 9 years ago 
The locales were set after the Pensieve connector was initialized (where the 
substitution occurs).
Try this new build:
http://okapi.opentag.com/snapshots/okapi-apps_win32-x86_64_0.27-SNAPSHOT.zip

Original comment by yves.sav...@gmail.com on 18 Dec 2014 at 3:40

GoogleCodeExporter commented 9 years ago 
The snapshot does not contain any changes.

Original comment by Uli.Laeg...@gmail.com on 19 Dec 2014 at 8:44

GoogleCodeExporter commented 9 years ago 
There was another place where the setting of the locale needed to be moved. 
This time I've tested the code.
The zip filete below should have the modification:
http://okapi.opentag.com/snapshots/okapi-apps_win32-x86_64_0.27-SNAPSHOT.zip

Original comment by yves.sav...@gmail.com on 19 Dec 2014 at 1:12

GoogleCodeExporter commented 9 years ago 
Perfect, now it works.
Thanks.

Original comment by Uli.Laeg...@gmail.com on 19 Dec 2014 at 1:35

GoogleCodeExporter commented 9 years ago 
Fixed with: 
https://code.google.com/p/okapi/source/detail?r=88d0ffe910cd52260f6e55e44855e395
bda71303&name=dev

Original comment by yves.sav...@gmail.com on 19 Dec 2014 at 3:17