search

computerlyrik / dymoprint

Linux Software to print with LabelManager PnP from Dymo
Apache License 2.0
150 stars 51 forks source link

Some random small changes #107

Closed tomers closed 5 months ago

tomers commented 5 months ago

Hey guys,

Could you please these reviews? There's some small things I've collected in the meanwhile.

maresb commented 5 months ago

Wonderful!!! Excellent work!

Two thoughts:

  1. I wonder if we should try to make the USB device accessible from the dev container. For example, a quick Google search turned up a SO thread with a few potential ideas. It would be nice, but it's not so big of a priority.
  2. The TOML formatting seems to come from the tamasfe.even-better-toml extension. Ideally we should enforce formatting with pre-commit, but there doesn't seem to exist a hook yet for the formatter used by that extension. I made a really quick feature request for it.

Thanks so much for moving this forward.