search

computerlyrik / dymoprint

Linux Software to print with LabelManager PnP from Dymo
Apache License 2.0
150 stars 51 forks source link

Tomer fixes #108

Closed tomers closed 5 months ago

tomers commented 5 months ago

Some more improvements. Mainly separation of code, and create helper classes.

maresb commented 5 months ago

Excellent as usual, thanks @tomers!!!

When I ran it I hit some exceptions, e.g. with super and Path vs str. I fixed them in my suggestions here: https://github.com/tomers/dymoprint/pull/2

If you feel so motivated, it would be nice to get rid of that die function, it feels very Perl. :joy:

Are you familiar with mypy? It'd be amazing to have this code statically type-checked.

maresb commented 5 months ago

See also https://github.com/tomers/dymoprint/pull/3

maresb commented 5 months ago

And mypy: https://github.com/tomers/dymoprint/pull/4

tomers commented 5 months ago

Thank you so much @maresb ! It's really a pleasure to work with you. You are very responsive and helpful. You contribute a lot in a to my PRs, in a timely manner, and I got to learn a lot from you :heart: Thanks!

maresb commented 5 months ago

Likewise!!! I'm very happy to have your energy and enthusiasm to move things so far forward here! The codebase is in much better shape since you came along.