search

computerlyrik / dymoprint

Linux Software to print with LabelManager PnP from Dymo
Apache License 2.0
151 stars 51 forks source link

Tomer fixes #110

Closed tomers closed 8 months ago

tomers commented 8 months ago

Some more fixes :-)

tomers commented 8 months ago

This looks really amazing as usual @tomers!!! These are some really huge improvements to the quality and structure of the code.

I think there's a design aspect that we should ensure we agree on: the debug/verbose mode. Given the experimental nature of this project, I feel inclined to make things verbose by default. If a user asks for help it's just another step to ask them to turn on debug to get the stack trace. If we do decide it's the way to go, I would have expected to see it via command line arguments, and not just through environment variables. What do you think?

I think the program needs to be regarded as stable with regards to how it looks, i.e. there should not be traceback information shown in dialog boxes, etc. Our users are not software developers, so they should not see it. I set command line options to control verbosity level, in addition to the environment variables.

maresb commented 8 months ago

Amazing work as usual, thanks so much @tomers!!!!!