search

computerlyrik / dymoprint

Linux Software to print with LabelManager PnP from Dymo
Apache License 2.0
150 stars 51 forks source link

Add `--test-pattern` CLI option #89

Closed tomek-szczesny closed 8 months ago

tomek-szczesny commented 8 months ago

Here's a little pattern generating code. It may have to be worked on because I'm not sure if it's sent to the printer faithfully.

The bigger pattern indeed sends more data to the printer even though its physical size is the same, so I reckon this should work.

tomek-szczesny commented 8 months ago

Before this gets pulled, I'd like to add some horizontal lines after the checkerboard. I've got a nice idea for it.

And perhaps --test-pattern argument should ignore all other arguments, because the following prints are obviously misaligned (canvas of a wrong size).

maresb commented 8 months ago

Ok, just let me know when you're ready. It's good enough for me. I can't be bothered at the moment to fix #88.

tomek-szczesny commented 8 months ago

I think this is ready for a pull.

maresb commented 8 months ago

For discoverability, I'd like to do the matrix optimization removal in a separate PR. (I'm thinking that at some point in the future if we support huge labels then it'd be nice to have a clean reference to the point when that code was removed.)

That stuff can be super-annoying if you're not a frequent Git user. Would you like me to crank that out for you?

tomek-szczesny commented 8 months ago

For discoverability, I'd like to do the matrix optimization removal in a separate PR. (I'm thinking that at some point in the future if we support huge labels then it'd be nice to have a clean reference to the point when that code was removed.)

That stuff can be super-annoying if you're not a frequent Git user. Would you like me to crank that out for you?

I would appreciate that, thanks.

But I'm not sure if it makes any difference - it is a separate commit after all. You can pull in such a way that the whole pull request isn't seen as a single commit. I think I've done that once. :)

maresb commented 8 months ago

But I'm not sure if it makes any difference - it is a separate commit after all.

This is true except for the automatic release notes, which are on a per-PR basis, and that's what I'm aiming for.

You can pull in such a way that the whole pull request isn't seen as a single commit.

Ya, that's the squash-merge. I'll do it here.

tomek-szczesny commented 8 months ago

Sorry, I just found one last bug. ;)

The horizontal line pattern was one dot off.

maresb commented 8 months ago

@tomek-szczesny, I cherry-picked your commit to a branch remove-dottab-matrix-opt. Are you able to open a PR for it? For me it works via this link: https://github.com/computerlyrik/dymoprint/compare/remove-dottab-matrix-opt?expand=1

tomek-szczesny commented 8 months ago

@maresb sorry I can't. I have to be a collaborator, the error says.