search

computerminds / cm_config_tools

DEPRECATED: Mirror of http://cgit.drupalcode.org/cm_config_tools
1 stars 0 forks source link

Remove old implied dependencies #6

Closed anotherjames closed 7 years ago

anotherjames commented 7 years ago

If a dependency was implied, and is no longer a dependency, it should be removed from /config/install. Just do this to any files that are not needed to be exported that still exist in /config/install (i.e. by diffing the list of existing files with the list of files to export (including those that have not changed btw), as we consider ourselves as tightly managing /config/install)

If we wanted to allow arbitrary config in /config/install that is not covered by cm_config_tools, we would need a specific list of implied dependencies - for example, either adding them to the info file, or put any dependencies inside /config/install/dependencies, and modify the ConfigInstaller to get config from there on install/etc too - though that could be tricky and gets further from recognisable core functionality as well. Ultimately, cm_config_tools really will just work on anything in /config/install rather than limiting itself to what is listed as managed, so I think it's ok to consider anything in that dir as tightly managed.

If an implied dependency is [to be] removed on exporting though, we should at least flag that up as a warning/notice, potentially even before actually exporting so the developer can cancel the export and make it explicitly managed?

anotherjames commented 7 years ago

Resolved in latest commit(s) f308428adc0487fea0e61071f86aa62c1685daf9.