search

computernewb / collabvm-1.2.ts

CVM1 clone in TypeScript since cvm1.2.11 decided to nuclear explode
GNU General Public License v3.0
9 stars 17 forks source link

Virtual machine freezes when shut down #3

Closed enderman0125 closed 1 year ago

enderman0125 commented 1 year ago

Title says it all. I only started noticing this problem recently when a couple of my users started shutting down the VMs. In the old server, this would just restart the VM as usual. In the new one, it freezes (I assume QEMU is exiting?).

In src/QEMUVM.ts at line 47:

this.qemuCmd = ${Config.vm.qemuArgs} -snapshot -no-shutdown -vnc 127.0.0.1:${this.vncPort - 5900} -qmp ${this.qmpType}${this.qmpSock},server;

It is obviously passing -no-shutdown, however this has no effect. I am running the copy from Feb 9 2023, so this may have been fixed? Or this has been a recurring problem.

enderman0125 commented 1 year ago

This also seems to happen on the main CollabVM instance (seen on VM8)

MDMCK10 commented 1 year ago

Resolved by https://github.com/computernewb/collabvm-1.2.ts/commit/87cefdaabaf844c0345abd8760e4170bf16b5816