computerscience-person / Group2_WebApp-CCS227

Small static website using Vite + React + Tailwind.
https://computerscience-person.github.io/Group2_WebApp-CCS227/
0 stars 3 forks source link

Broken product page #8

Closed computerscience-person closed 1 month ago

computerscience-person commented 1 month ago

image

Here, it shows how there's an overflow somewhere in the web page, making the navbar not extend

image

Here, the centering of the page starting from the showcase of the products looks wrong.

image

It also breaks the footer. Looking from this part, it seems like the product showcase is centered from the middle of the containing div that overflowed.

computerscience-person commented 1 month ago

https://github.com/computerscience-person/Group2_WebApp-CCS227/blob/8902bab99202538f25f1179a831ce5df722cd3d8/src/components/ProductDiv.tsx#L30

You're trying to use a flexbox specific CSS here without a parent flexbox. items-center only works inside flexboxes or grids.

computerscience-person commented 1 month ago

All in all, maybe you should take the time to read up on flexboxes and try to refactor your code to (properly) use flexboxes.

computerscience-person commented 1 month ago

Some issues fixed by #14, but some issues still remain. Issue open for now.

computerscience-person commented 1 month ago

Fixed with #14 and #17.