CP-1006 Strip extension config

computmaxer / karma-jspm

Other

74 stars 50 forks source link

Closed valotas closed 8 years ago

valotas commented 8 years ago

Made the module name computation configurable.

maxwellpeterson-wf commented 8 years ago

You'll need to pass the config onto the client in init.js similar to here: https://github.com/Workiva/karma-jspm/blob/master/src/init.js#L78

valotas commented 8 years ago

Done.

Why don't you just copy the whole object? It is very easy to forget to do that otherwise.

trentgrover-wf commented 8 years ago

+1 @maxwellpeterson-wf @evanweible-wf

maxwellpeterson-wf commented 8 years ago

@valotas good point, we should do that. Want to submit a patch? :)

+1 @jayudey-wf ready for merge

valotas commented 8 years ago

Sure. I'll have a look at it within the week

evanweible-wf commented 8 years ago

jayudey-wf commented 8 years ago

QA Resource Approval: +10

[x] Testing instruction (gathered from discussion with Max Peterson)
[x] Dev +1's
[x] Dev/QA +10 with detail of what was tested
- installed in another project that consumes karma-jspm, verified that tasks were still working as expected
[ ] Unit test created/updated
[x] All unit tests pass

Merging into mast