search

computmaxer / karma-jspm

Other
74 stars 50 forks source link

CP-1062 eslint, karma-jspm #101

Closed valotas closed 8 years ago

valotas commented 8 years ago

Make use of basic eslint rules and fixed warnings

valotas commented 8 years ago

Done

rmconsole2-wf commented 8 years ago

@valotas This pull request has merge conflicts, please resolve.

trentgrover-wf commented 8 years ago

+1 @maxwellpeterson-wf @jayudey-wf

rmconsole2-wf commented 8 years ago

@valotas This pull request has merge conflicts, please resolve.

dustinlessard-wf commented 8 years ago

@valotas , If we intend on moving ahead with this, can you resolve the merge conflicts?

valotas commented 8 years ago

@dustinlessard-wf I almost forgot that.

I fixed the conflicts last time, but I don't feel like doing it every month or so :). So let me know if you feel like merging it and I'll fix them.

evanweible-wf commented 8 years ago

@valotas would you mind merging this PR to address the merge conflicts? https://github.com/valotas/karma-jspm/pull/1

valotas commented 8 years ago

@evanweible-wf I've merged your pr but there were some remaining warnings that I've fixed. It looks like this PR can be merged now. Thanks a lot for the pr anyway!

evanweible-wf commented 8 years ago

+1

@trentgrover-wf @maxwellpeterson-wf @dustinlessard-wf

dustinlessard-wf commented 8 years ago

+1

maxwellpeterson-wf commented 8 years ago

+1

trentgrover-wf commented 8 years ago

@jayudey-wf ready for merge

jayudey-wf commented 8 years ago

QA Resource Approval: +10

Merging into master.