Closed ahelmberger closed 8 years ago
@maxwellpeterson-wf @evanweible-wf
+1 once Trent's comment has been addressed
@ahelmberger This pull request has merge conflicts, please resolve.
Thanks for the feedback, I rebased on the current master and used the IE8-compatible syntax.
+1
+1 @maxwellpeterson-wf @jayudey-wf
+1
QA Resource Approval: +10
Merging into master.
We would like to make the order, in which modules are loaded, deterministic. They should be imported in the order specified in
karma.conf.js
. E.g. given this configuration:The current implementation would attempt to load all modules simultaneously. This can lead to different behavior between test runs, especially in the above case, where the first module adds some global polyfills other modules rely on.
With this changeset, all files specified in the
loadFiles
array will be imported sequentially.From a perfomance perspective: we could not notice any difference between simultaneous/sequential import, tested in a project with about 400 tests and about 170 modules.