CP-1068 Fixes #104: Module interpreted as global module format

computmaxer / karma-jspm

Other

74 stars 50 forks source link

Closed alexcastillo closed 8 years ago

alexcastillo commented 8 years ago

Fixes #104

Error: Module interpreted as global module format, but called System register Solution: Add support to custom meta in karma-jspm config.

Thanks @larrifax for the help.

maxwellpeterson-wf commented 8 years ago

+1 @trentgrover-wf

trentgrover-wf commented 8 years ago

+1 @jayudey-wf ready for merge

alexcastillo commented 8 years ago

Thanks for the +1 @maxwellpeterson-wf @trentgrover-wf

jayudey-wf commented 8 years ago

QA Resource Approval: +10

[x] Testing instruction (provided by Max Peterson)
[x] Dev +1's
[x] Dev/QA +10 with detail of what was tested
- installed into project that consumes karma-jspm and commands were still working as expected
[ ] Unit test created/updated
[x] All unit tests pass

Merging into master.

alexcastillo commented 8 years ago

Thanks everyone!