computmaxer / karma-jspm

Other
74 stars 50 forks source link

Remove versions from paths to systemjs and s6-module-loader #11

Closed maxwellpeterson-wf closed 10 years ago

maxwellpeterson-wf commented 10 years ago

Fixes #10. Should be released as a new breaking change (either 1.1.0 or 2.0.0).

Problem

jspm no longer puts a version string in the filenames for system.js and es6-module-loader.js after version 0.8.0

Solution

Update the file paths to these files.

Testing

Use karma-jspm in a project that is using jspm@0.8.0-beta.4

@trentgrover-wf

maxwellpeterson-wf commented 10 years ago

@trentgrover-wf Fixed, ready for review

maxwellpeterson-wf commented 10 years ago

@trentgrover-wf fixed so that this is not a breaking change AND it doesn't throw unnecessary warnings.

trentgrover-wf commented 10 years ago

+10

@charliekump-wf QA+1 and merge please

charliekump-wf commented 10 years ago

QA Resource Approval: +1

Merging into master.