CP-1340 feat(config): nocache support for jspm.loadFiles Closes #114 (additionally #113)

computmaxer / karma-jspm

Other

74 stars 50 forks source link

CP-1340 feat(config): nocache support for jspm.loadFiles Closes #114 (additionally #113) #115

Closed comdiv closed 8 years ago

comdiv commented 8 years ago

Forces file reread in watch cycle (required for tests in current edit) Additionally common problem with testing on windows fixed

Closes #114 #113

RomanHotsiy commented 8 years ago

@comdiv can you add nocache support for jspm_packages dir as well ? Without that karma crashes on OS X because of too many opened files at the same time.

Adding the following line: jspmPattern.nocache = jspm.nocache; after this one and specifying nocache: true in options helps.

Can you please add this feature to your PR? (I can do own PR but just don't want to multiply PRs)

comdiv commented 8 years ago

ok will try

fabioelia commented 8 years ago

+1 Cause for alot of headaches please get a PR going for this. "EMFILE: too many open files..."

NateRedding commented 8 years ago

+1 Please merge!!

maxwellpeterson-wf commented 8 years ago

+1 @trentgrover-wf @evanweible-wf FYI @jayudey-wf

evanweible-wf commented 8 years ago

trentgrover-wf commented 8 years ago

+1 @jayudey-wf ready for merge

jayudey-wf commented 8 years ago

QA Resource Approval: +10

[x] Testing instruction (derived from conversation with Max Peterson)
[x] Dev +1's
[x] Dev/QA +10 with detail of what was tested
- passing CI w/ updated tests
[x] Unit test created/updated
[x] All unit tests pass

Merging into master.