CP-1447 Support for JSPM 0.17 Beta

computmaxer / karma-jspm

Other

74 stars 50 forks source link

CP-1447 Support for JSPM 0.17 Beta #129

Closed rafiwardak2003 closed 8 years ago

rafiwardak2003 commented 8 years ago

Added an option to pass a jspm.browser.js file needed for JSPM 0.17 Beta.

SerkanSipahi commented 8 years ago

Who will merge this into master ?

rafiwardak2003 commented 8 years ago

Not sure... but if anyone is trying out JSPM beta 0.17, they might need this with it.

maxwellpeterson-wf commented 8 years ago

+1 @trentgrover-wf @evanweible-wf

trentgrover-wf commented 8 years ago

+1 @jayudey-wf ready for merge

evanweible-wf commented 8 years ago

SerkanSipahi commented 8 years ago

+1 sounds good

MSakamaki commented 8 years ago

rolandjitsu commented 8 years ago

Is anyone actually going to merge this and release?

evanweible-wf commented 8 years ago

@jayudey-wf

maxwellpeterson-wf commented 8 years ago

+10

confirmed that adding a browser option to jspm in the config causes karma to load the browser file.
confirmed omitting browser causes no request to be made

jayudey-wf commented 8 years ago

QA Resource Approval: +1

[x] Testing instruction (derived by Max)
[x] Dev +1's
[x] Dev/QA +10 with detail of what was tested
- performed and documented by Max
[ ] Unit test created/updated
[x] All unit tests pass

Merging into master.

SerkanSipahi commented 8 years ago

yeaaah, its merged :+1:

SerkanSipahi commented 8 years ago

@jayudey-wf @maxwellpeterson-wf @evanweible-wf @trentgrover-wf Thank you guys. I have a complex project that was based on karma-jspm 2.0.3. The change to 2.1.0 was without problems :)