search

computmaxer / karma-jspm

Other
74 stars 50 forks source link

CP-1770 expandedFiles now update when files are added/removed. #131

Closed FrederikNJS closed 8 years ago

FrederikNJS commented 8 years ago

Fixes #121

I was quite annoyed that karma-jspm didn't load new files when they were added. So I found out that there is a file_list_modified event emitted from karma, when the file list changes. I simply injected the emitter and wrapped the expandedFiles assignment in it.

I have tested the change against one of my own projects, and running karma in watch mode now correctly loads new files when I add them.

Hope you like it ;-)

FrederikNJS commented 8 years ago

Hmm, tests seem to be failing, I'll see what I can do.

EDIT: Tests run as they should now.

rmconsole2-wf commented 8 years ago

@FrederikNS This pull request has merge conflicts, please resolve.

FrederikNJS commented 8 years ago

Merge Conflicts are fixed.

maxwellpeterson-wf commented 8 years ago

+1 This looks good to me! Thank you for the contribution @FrederikNS!

@trentgrover-wf @evanweible-wf

evanweible-wf commented 8 years ago

+1

trentgrover-wf commented 8 years ago

+1 @jayudey-wf ready for merge

jayudey-wf commented 8 years ago

QA Resource Approval: +10

Merging into master.