search

computmaxer / karma-jspm

Other
74 stars 52 forks source link

CP-1790 Replace gulp-jasmine by plain jasmine #154

Closed svi3c closed 8 years ago

svi3c commented 8 years ago

The problem with the gulp-jasmine plugin was that failing tests do not make the travis build fail. By using plain jasmine we achieve this failing of the tests. As a nice side effect our dependencies are much more light-weight and the tests are executed faster.

Resolves #153

Note: At the moment this test fails, since the tests are failing in the master branch.

evanweible-wf commented 8 years ago

Thanks @svi3c! We'll take a look at the failing tests and see if we can get this change merged along with the fixes.

evanweible-wf commented 8 years ago

@trentgrover-wf @maxwellpeterson-wf @dustinlessard-wf @sebastianmalysa-wf @jayudey-wf

svi3c commented 8 years ago

@evanweible-wf Maybe you can have a look at https://github.com/Workiva/karma-jspm/pull/149 which contains a fix for the tests.

trentgrover-wf commented 8 years ago

+1

maxwellpeterson-wf commented 8 years ago

+1

evanweible-wf commented 8 years ago

@svi3c sorry - didn't realize #149 also fixed the tests. Thanks for doing that!

+1

@jayudey-wf ready for test/merge

jayudey-wf commented 8 years ago

QA Resource Approval: +10

Merging into master.