computmaxer / karma-jspm

Other
74 stars 52 forks source link

CP-1962 support jspm.config as array #156

Closed amitport closed 8 years ago

amitport commented 8 years ago

we have a slightly big project that involves several connected projects. We often load more then one files that contains systemjs configuration.

(using jspm.browser.js can be considered a specialized use case, and the current jspm.browser should be deprecated IMO)

svi3c commented 8 years ago

+1 I would like to use this feature, too. JSPM does some auto-generation of the config files which can be excluded from version control when splitting up the config files.

trentgrover-wf commented 8 years ago

+1 @evanweible-wf @maxwellpeterson-wf @jayudey-wf

evanweible-wf commented 8 years ago

+1

trentgrover-wf commented 8 years ago

@jayudey-wf ready for merge

jayudey-wf commented 8 years ago

@amitport can you provide a test with this change

evanweible-wf commented 8 years ago

@amitport I made a PR to add a test for this functionality, would you mind taking a look and merging it? Then we can get this PR merged.

https://github.com/amitport/karma-jspm/pull/1

trentgrover-wf commented 8 years ago

@jayudey-wf @evanweible-wf let's merge this PR and @evanweible-wf can make a separate PR with the test for merge

evanweible-wf commented 8 years ago

+1

evanweible-wf commented 8 years ago

@trentgrover-wf @maxwellpeterson-wf the PR to add a test for this change was merged, let's get this PR merged now.

maxwellpeterson-wf commented 8 years ago

+1

jayudey-wf commented 8 years ago

QA Resource Approval: +10

Merging into master.