search

computmaxer / karma-jspm

Other
74 stars 52 forks source link

Fixes #158 - add options for dev/node config files #159

Closed sergei-maertens closed 8 years ago

sergei-maertens commented 8 years ago

This adds two more config file options that are available in jspm 0.17 beta

evanweible-wf commented 8 years ago

+1 Thanks @sergei-maertens!

@trentgrover-wf @dustinlessard-wf

sergei-maertens commented 8 years ago

Fwiw, in the long term the suggested approach of #156 might be more viable, either would be fine for me.

trentgrover-wf commented 8 years ago

I'd vote to go with #156 instead since it's the more generalized solution

thoughts @maxwellpeterson-wf @evanweible-wf ?

sergei-maertens commented 8 years ago

I only saw it after I submitted the PR ofcourse, so +1 from me on #156 as well On Jun 7, 2016 17:01, "trentgrover-wf" notifications@github.com wrote:

I'd vote to go with #156 https://github.com/Workiva/karma-jspm/pull/156 instead since it's the more generalized solution

thoughts @maxwellpeterson-wf https://github.com/maxwellpeterson-wf @evanweible-wf https://github.com/evanweible-wf ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Workiva/karma-jspm/pull/159#issuecomment-224308818, or mute the thread https://github.com/notifications/unsubscribe/AFQ01nUCLITRAIhK_9ZK_UPMs3Fw-pXqks5qJYfKgaJpZM4Ivxo- .

evanweible-wf commented 8 years ago

That works for me, I'll go ahead and close this.