search

computmaxer / karma-jspm

Other
74 stars 50 forks source link

add adapter option #165

Closed jerryorta-dev closed 2 years ago

jerryorta-dev commented 8 years ago

This PR is related to #164 and potentially #162.

This is a non-breaking change in that if no custom adapter is provided, the default adapter is used.

A sample implementation is here: https://github.com/UIUXEngineering/angular2-seed-jspm/blob/master/src/client/jspm.karma.ng2.adapter.js

aviary2-wf commented 8 years ago

Raven

Number of Findings: 0

maxwellpeterson-wf commented 8 years ago

What do you need to do in a custom karma-jspm adapter that can't be done in a regular included JS file or a separate plugin?

jerryorta-dev commented 8 years ago

There is a race condition with files served ( and loaded ). I'm using the systemjs loader promise to ensure files are loaded prior to karma.start is called. Plus, there are angular2 conventions used to initiated unit tests.

https://github.com/UIUXEngineering/angular2-seed-jspm/blob/karma/src/client/jspm.karma.ng2.adapter.js#L96

aviary-wf commented 8 years ago

Raven

Number of Findings: 0