computmaxer / karma-jspm

Other
74 stars 50 forks source link

Default to ignoring jspm bundles, overridable with config #17

Closed maxwellpeterson-wf closed 10 years ago

maxwellpeterson-wf commented 10 years ago

Problem

If bundles are defined in config.js, systemjs will load the bundle instead of source files contained in the bundle. The default behavior should be to test source files individually, while allowing users to opt-in to testing using the bundle.

Solution

Add useBundles option. If not specified, karma-jspm will override the bundles config with an empty array.

Testing

@trentgrover-wf @evanweible-wf @guybedford-wf

guybedford-wf commented 10 years ago

Looks great to me.

trentgrover-wf commented 10 years ago

+1

evanweible-wf commented 10 years ago

+10

@charliekump-wf ready for merge

charliekump-wf commented 10 years ago

QA Resource Approval: +1

Merging into master.