search

computmaxer / karma-jspm

Other
74 stars 52 forks source link

Remove extra function wrap #170

Open unional opened 8 years ago

unional commented 8 years ago

Fix #169

System.import() returns a promise. .then() accepts a promise in return, not a function.

aviary-wf commented 8 years ago

Raven

Number of Findings: 0

unional commented 8 years ago

karma.start() was being called automatically when certain time has passed, not from this line: https://github.com/Workiva/karma-jspm/blob/master/src/adapter.js#L65

If you added console.log('karma.start())` to it, you can see it is not being called.

This is because after the first call, the promiseChain resolved to a function with other System.import() calls, so they are "detached" and not tracked.

3cp commented 6 years ago

Why there is no follow up for this much needed fix?