computmaxer / karma-jspm

Other
74 stars 52 forks source link

CP-2409 Update glob dependency #173

Closed BBosman closed 7 years ago

BBosman commented 7 years ago

Currently installing karma-jspm gives a warning:

npm WARN deprecated minimatch@0.3.0: Please update to minimatch 3.0.2 or higher to avoid a RegExp DoS issue

This PR updates the glob dependency to the most recent version which uses an updated minimatch version as well.

I ran the tests after the change and they all still pass.

This PR should also fix #166.

aviary2-wf commented 7 years ago

Raven

Number of Findings: 0

evanweible-wf commented 7 years ago

+1

@maxwellpeterson-wf @trentgrover-wf

maxwellpeterson-wf commented 7 years ago

+1 @jayudey-wf ready for merge.

jayudey-wf commented 7 years ago

QA Resource Approval: +10

Merging into master.