Fix "Error" when using jspm v0.17.0-beta.35

[SerkanSipahi]

jspm v0.17.0-beta.35 throw an error when it used with karma-jspm v2.2.0:

Uncaught Error: Setting `SystemJS.bundles` directly is no longer supported. Use `SystemJS.config({ bundles: ... })`.

This commit will solve this issue. Instead of System.bundles = [];, System.config({ bundles: [] }); should be used.

[aviary-wf]

Raven

Number of Findings: 0

[SerkanSipahi]

@jayudey-wf please merge the pull request otherwise karma-jspm cant be used with jspm v0.17.0-beta.35. Please also publish it then on npm, thanks :)

[jayudey-wf]

@Workiva/web-platform-pp

[SerkanSipahi]

@jayudey-wf the team-member link @Workiva/web-platform-pp does not work. It show an error (404) page. I hope you know what you're doing :)

[trentgrover-wf]

+1

[maxwellpeterson-wf]

@SerkanSipahi it only works within the "Workiva" organization, but it successfully notified us.

+1 This should probably be released in a major version.

[SerkanSipahi]

@trentgrover-wf @maxwellpeterson-wf @jayudey-wf jspm have breaking changes in v0.17.0-beta.35 due system has been upgraded from v0.19 to v0.20.x. @guybedford recommend:

https://github.com/systemjs/systemjs/releases/tag/0.20.0

To upgrade, first run SystemJS 0.19 with System.config({ warnings: true }) and fix all the deprecation

We should add important release (0.20.0) notes to karma-jspm README.md

[SerkanSipahi]

@trentgrover-wf @maxwellpeterson-wf @jayudey-wf when is the next major release? :)

Is there any possibility/option for me to maintain this repository, too?

[SerkanSipahi]

@trentgrover-wf @maxwellpeterson-wf @jayudey-wf any updates for merging this into master + releaseid ?

[SerkanSipahi]

@trentgrover-wf @maxwellpeterson-wf @jayudey-wf why does it take so long?

[trentgrover-wf]

QA +1

• [x] Testing instruction
• [x] Dev +1's
• [x] Dev/QA +10 with detail of what was tested
  • inferred +10 from external contributor
• [x] Unit tests created/updated
  • unnecessary
• [x] All unit tests pass

Merging into master.

[SerkanSipahi]

thank you all :)

[trentgrover-wf]

Sorry for the delay. We're no longer using this tool much internally (we're using Dart for most of our ongoing development), so unfortunately its maintenance isn't our highest priority. I've pinged @guybedford to see if we can transfer the repo over to the jspm org so that it gets the attention the community deserves.

[SerkanSipahi]

@trentgrover-wf can you publish karma-jspm v2.2.1 on npm, please? thank you

[guybedford]

@trentgrover-wf thanks for the notification here. Unfortunately I also have limited resources to maintain third-party projects in the main SystemJS repo, so ideally this is something that can be picked up by the community, and handed over into a community repo or that persons repo.

Ideally someone can pick up this responsibility and offer to put the maintenance effort in. Have there been any contributors to this project that would be interested in becoming maintainers?

[guybedford]

@SerkanSipahi would you perhaps be interested in maintaining this project yourself?

[SerkanSipahi]

@guybedford sure :)

[guybedford]

@SerkanSipahi I'm not in a position to make the decision here, but this is something you could possibly discuss further with @trentgrover-wf.

[SerkanSipahi]

@travisensley-wf im interested in maintaining this project. Is that possible?

[trentgrover-wf]

@SerkanSipahi I would gladly have you join as a maintainer. I'll verify with the powers that be whether or not there's any additional steps to take on my end and email you ASAP with details.

Thanks for volunteering.

[computmaxer]

@SerkanSipahi I've added you as a collaborator on the repository (please note it has moved from Workiva/karma-jspm to computmaxer/karma-jspm).

[SerkanSipahi]

@computmaxer @trentgrover-wf @guybedford thank you :)