search

computmaxer / karma-jspm

Other
74 stars 50 forks source link

CP-380 properly declare variables as local, not as globals #35

Closed capaj closed 9 years ago

capaj commented 9 years ago

that's like the first rule of javascript

dafuq

maxwellpeterson-wf commented 9 years ago

+1

evanweible-wf commented 9 years ago

+1

trentgrover-wf commented 9 years ago

+1

maxwellpeterson-wf commented 9 years ago

@jayudey-wf ready for merge and patch tag

jayudey-wf commented 9 years ago

QA +1, no functional changes - just a code bestpractice

Merging