computmaxer / karma-jspm

Other
74 stars 50 forks source link

CP-591 customizable paths #47

Closed zewa666 closed 9 years ago

zewa666 commented 9 years ago

if the jspm conf section inside the karma.conf file contains a paths object, this will be used to override path settings. This is helpful if your test environment needs to have different basepaths compared to your production environment.

The Aurelia Team uses karma-jspm as a core workflow tool for unit testing across all repos. This feature would be very important in order to get our test suite working properly.

plwalters commented 9 years ago

Can anyone please update what needs to be fixed to merge this in?

maxwellpeterson-wf commented 9 years ago

Sorry, this PR must have gotten buried. +1 looks good. @trentgrover-wf @evanweible-wf

plwalters commented 9 years ago

Cool thanks for the response!

maxwellpeterson-wf commented 9 years ago

Actually @zewa666 or @PWKad could one of you add something to the README detailing this configuration option (and why it exists) under the "## Optional Configuration" section?

zewa666 commented 9 years ago

@maxwellclarke-wf sry you're right I forgot about that. the latest commit adds those as well

evanweible-wf commented 9 years ago

+1

zewa666 commented 9 years ago

@maxwellpeterson-wf you're right ... not sure how that happend but it should be fixed now

evanweible-wf commented 9 years ago

+1

maxwellpeterson-wf commented 9 years ago

+10

jspm: {
    paths: {
        maxwell: 'peterson/*.js'
    }
}

sc

@jayudey-wf ready for merge

jayudey-wf commented 9 years ago

QA Resource Approval: +1

Merging into master.

zewa666 commented 9 years ago

You guys seem pretty organized about git processes ... respect :+1: Thanks for merging this

maxwellpeterson-wf commented 9 years ago

Yeah, we have somewhat strict requirements for auditing purposes since our company deals with customer financial data. It does help code quality though!

No problem, sorry for the delay in responding to the PR.