CP-545 Allow karma (with karma-jspm) to be run from different directory then karma.conf.js file's dir

computmaxer / karma-jspm

Other

74 stars 50 forks source link

CP-545 Allow karma (with karma-jspm) to be run from different directory then karma.conf.js file's dir #48

Closed finalclass closed 9 years ago

finalclass commented 9 years ago

If you would try to run karma from different directory then the one where the karma.conf.js is located then karma-jspm would not resolve file locations correctly. This is due to usage of process.cwd() instead of basePath. This pull request fixes this issue.

maxwellpeterson-wf commented 9 years ago

+1 @trentgrover-wf @evanweible-wf

trentgrover-wf commented 9 years ago

evanweible-wf commented 9 years ago

maxwellpeterson-wf commented 9 years ago

@jayudey-wf this is ready for test

jayudey-wf commented 9 years ago

QA Resource Approval: +10

[x] Testing instruction (received from max peterson)
[x] Dev +1's
[x] Dev/QA +10 with detail of what was tested
- tests pass, when this branch is installed into a project gulp test is still working as expected
[x] Unit test created/updated
[x] All unit tests pass

Merging into master.