Add error message when SystemJS is missing

computmaxer / karma-jspm

Other

74 stars 50 forks source link

Add error message when SystemJS is missing #5

Closed maxwellpeterson-wf closed 10 years ago

maxwellpeterson-wf commented 10 years ago

Fixes #2

Testing

Try running tests without a jspm_packages directory.

@trentgrover-wf

trentgrover-wf commented 10 years ago

can you add some more info about how to test this @maxwellpeterson-wf ? I don't understand the context of the issue

computmaxer commented 10 years ago

The issue is that when SystemJS isn't present on the filesystem and karma-jspm can't load it, the previous error was less clear. Something like "undefined has no method 'import'". This will add an error telling the user that the issue is the lack of SystemJS

trentgrover-wf commented 10 years ago

+10

test pass
operates as expected (more specific error message displayed with missing jspm_modules folder)

trentgrover-wf commented 10 years ago

@charliekump-wf ready to merge

charliekump-wf commented 10 years ago

QA Resource Approval: +1

[x] Testing instruction
[x] Dev +1's
[x] Dev/QA +10 with detail of what was tested
[ ] Unit test created/updated
- Existing coverage.
[x] All unit tests pass

Merging into master.