search

computmaxer / karma-jspm

Other
74 stars 50 forks source link

CP-767 Save CPU cycles by not watching jspm_packages directory for changes. #53

Closed ggranum closed 9 years ago

ggranum commented 9 years ago

One could also set usePolling to false and pray.

maxwellpeterson-wf commented 9 years ago

Thanks for the contribution! You'll need to fix this line of the unit test: https://github.com/Workiva/karma-jspm/blob/master/test/testInit.spec.js#L58 in order to get a passing build.

trentgrover-wf commented 9 years ago

@maxwellpeterson-wf looks like this PR was abandoned, so if it's useful, might as well finish it off yourself

ggranum commented 9 years ago

@maxwellpeterson-wf I'm a bit embarrassed that I didn't run the tests on the unit-testing addon :~) Thanks for pointing out the exact line number.

@trentgrover-wf Thanks for comment. Crazy house move pushed this and a dozen other things off the end of the queue. I needed the reminder, sadly.

trentgrover-wf commented 9 years ago

+1

gavinaiken commented 9 years ago

I was just about to contribute a PR with the exact same purpose as this, glad someone else got there first! :+1: How often do you guys do releases i.e. when is this likely to be out on npm?

maxwellpeterson-wf commented 9 years ago

+1 @jayudey-wf ready for merge @gavinaiken I can get this in a patch release once it is merged and goes through our release process. Likely will be on npm tomorrow morning.

jayudey-wf commented 9 years ago

QA Resource Approval: +10

Merging into master.