search

computmaxer / karma-jspm

Other
74 stars 50 forks source link

SystemJS 0.17.0+ Support #58

Closed scott-coates closed 9 years ago

scott-coates commented 9 years ago

The new version of systemjs changes things a little bit.

It is no longer acceptable to change the baseURL after it's already been configured, this is necessary for the normalization process. See here: https://github.com/systemjs/systemjs/issues/514

Because this plugin defines the baseURL here SystemJS is throwing an exception.

OliverJAsh commented 9 years ago

See https://github.com/rich-nguyen/karma-jspm

OliverJAsh commented 9 years ago

Note we haven't updated the docs, you'll have to look at the code.

martinmicunda commented 9 years ago

@OliverJAsh is there plan to merge that into Workiva/karma-jspm repo?

maxwellpeterson-wf commented 9 years ago

@OliverJAsh we would gladly accept a PR!

martinmicunda commented 9 years ago

@OliverJAsh I tried your version rich-nguyen/karma-jspm but with SystemJS 0.18.0+ however it doesn't run any tests.

Chrome 43.0.2357 (Mac OS X 10.10.3): Executed 0 of 0 ERROR (0.003 secs / 0 secs)
maxwellpeterson-wf commented 9 years ago

Fixed in #61