CP-727 Fix compatibility with SystemJS 0.17+

[matoilic]

SystemJS 0.17+ requires the baseURL to be configured first and doesn't allow to change it once set. Also, es6-module-loader is not needed anymore. It has been replaced with systemjs-polyfills which are a stripped down version of es6-module-loader.

[maxwellpeterson-wf]

Thanks for the PR! +1

@evanweible-wf @trentgrover-wf

[trentgrover-wf]

+1

[trentgrover-wf]

@jayudey-wf ready for merge

[evanweible-wf]

+1

[jayudey-wf]

QA Resource Approval: +10

• [x] Testing instruction
• [x] Dev +1's
• [x] Dev/QA +10 with detail of what was tested
  • verified that without this change and on a newer version of SystemJS tests were not able to be run, after installing tests were able to be run as expected
• [x] Unit test created/updated
• [x] All unit tests pass

Merging into master.

[martinmicunda]

Is there plan to create new release and push it to npm?

[scott-coates]

Yes, please publish a new version on npm please. Thanks.

[martinmicunda]

@matoilic I tried your changes but I can't run any tests written in ES6 (I can run tests that are written in ES5)

describe('Employee', function(){
    const pp = 'test'; ----> this ES6 code cause that test doesn't run
    it('should run this test', function() {
        expect(true).toBe(true);
    });
});

output

PhantomJS 1.9.8 (Mac OS X 0.0.0): Executed 0 of 0 ERROR (0.001 secs / 0 secs)

[martinmicunda]

@matoilic sorry got that running with Chrome .. It seems ES6 doesn't work with PhantomJS

[scott-coates]

In my config.js, I've set the baseURL to "/". I think this is recommended.

So when init.js configures the expandedFiles property, my config.js file will be called, overwrriting the baseURL set here in karma-jspm. So if baseURL is overwritten, won't we be in the same situation?

Am I missing something? Thanks!

[martinmicunda]

@scoarescoare I got that run but with complications against master. My baseRL is set to "./" then I had to add this lines to my karma.conf.js file

        proxies: {
            '/jspm_packages/': '/base/jspm_packages/'
        },

then change this lines in init.js line 105 --> see bug #63

client.jspm.expandedFiles = flatten(jspm.loadFiles.map(function(file){
    files.push(createServedPattern(basePath + "/" + (file.pattern || file)));
    return expandGlob(file, basePath).map(function(path) {
      return '/base/' + path;
    });
  }));

[scott-coates]

I was in a rush to just get the tests to run for now, so I just did this:

// hack to get around karma-jspm - https://github.com/Workiva/karma-jspm/pull/61
const basePath = /\/base\//.test(System.baseURL) ? System.baseURL : "/";

System.config({
  "baseURL": basePath,
  ...
});

The idea being that if I was loading the environment from karma, I can assume that karma-jspm will have already set baseURL, so this is just a hack to not actually overwrite karma-jspm's config setting.

[dmackerman]

@martinmicunda ES6 works with PhantomJS if you include a bind() polyfill. I'm going to try your hack @scoarescoare.

[omerts]

+1 for releasing to npm

[maxwellpeterson-wf]

@martinmicunda @scoarescoare @mrydengren @omerts karma-jspm@2.0.0-beta.1 has been released and published to npm.

[scott-coates]

Thanks!