Prevent SystemJS from swallowing helpful errors

maxwellpeterson-wf commented 10 years ago

Should be merged after #6 as it was branched off of that

Problem

I was not attaching an error callback to the System.import promises that load the test specs. Turns out this causes SystemJS to silently fail when it came across a require statement that it didn't like. This would cause the promise never to resolve and as a result the tests would never run (karma.start() only gets called when all the promises resolve) - making debugging very difficult.

Solution

Add an error handler that throws any errors SystemJS has.

trentgrover-wf commented 10 years ago

+10

tests succeed
tested with autoPaw branch with karma-jspm proxy removed and all karma tests still succeed as expected
inserting a broken path in a test file also threw a reasonable error message to screen as expected

trentgrover-wf commented 10 years ago

@charliekump-wf merge-ready

charliekump-wf commented 10 years ago

QA Resource Approval: +1

[x] Testing instruction
[x] Dev +1's
[x] Dev/QA +10 with detail of what was tested
[ ] Unit test created/updated
- Not necessary, improved error handling.
[x] All unit tests pass

Merging into master.

computmaxer / karma-jspm

Prevent SystemJS from swallowing helpful errors #7

Problem

Solution