computmaxer / karma-jspm

Other
74 stars 50 forks source link

CP-821 Move overrides to after karma has loaded #84

Closed JeroenVinke closed 9 years ago

JeroenVinke commented 9 years ago

fixes https://github.com/Workiva/karma-jspm/issues/77

Config.js is loaded after the overrides causing 404 errors on all files. When you move the override to after karma has loaded, the overrides work and tests run normally again.

zewa666 commented 9 years ago

Funny I just found the solution few minutes after your PR, so yep agree that this should fix it. Good work @JeroenVinke :+1:

EisenbergEffect commented 9 years ago

Please merge and release with this fix as soon as you can! We really need this.

ghost commented 9 years ago

+1

maxwellpeterson-wf commented 9 years ago

+1 @jayudey-wf let's merge this and do a 2.0.1-beta.2 release

ghost commented 9 years ago

@maxwellpeterson-wf please do it today and remember to tag for npm!

ghost commented 9 years ago

@maxwellpeterson-wf today as in 2 hours ago :)

maxwellpeterson-wf commented 9 years ago

@robertbaker You have to understand that we have a QA and release process that we are required to go through internally. Our team is also very busy with a number of other things not related to this project, however, our QA does plan to get to this today. If that isn't quick enough for you, I'd recommend installing this specific branch of karma-jspm in your project. You can do so with the following command:

$ npm install "git+ssh://git@github.com:JeroenVinke/karma-jspm.git#master"
EisenbergEffect commented 9 years ago

@maxwellpeterson-wf Thanks for addressing this for us! We really appreciate you guys putting the effort in on this plugin.

jayudey-wf commented 9 years ago

QA Resource Approval: +10

Merging into master.

maxwellpeterson-wf commented 9 years ago

@robertbaker tag has been created and published.