search

computology / computology-packagecloud

Puppet module for packagecloud.io
Apache License 2.0
9 stars 29 forks source link

fix repo key updates on each puppet run #35

Open hensema opened 7 years ago

hensema commented 7 years ago

This PR fixes the repo key updates on each puppet run in issue #20

It properly uses the notify/refreshonly parameters on the resources. Now the key is only updated when the repository file is updated.

hensema commented 7 years ago

Please don't reject patches on formatting issues, it's offensive to your contributers (me). I don't know the requirements on each and every project.

I suggest embracing your contributors and reformatting the patch after accepting it. And leave them a note requesting proper formatting as per project requirements the next time.

Yggdrasil commented 7 years ago

@hensema Sorry, I'm not the maintainer. I probably should've made clearer that I'm just another contributer with some feedback in the hopes of getting this problem fixed. In my experience the better a pull request the more quickly it is merged since OSS maintainers are frequently busy people. Hence my suggestion, which is not a requirement or rejection at all. Again, thanks for your effort.