compwiz32 / PSADHealth

A toolkit of AD specific health checks that you can run in your environment to ensure your Active Directory is running optimally.
GNU General Public License v2.0
149 stars 19 forks source link

Verbosity and Examples updates as well as some functional updates #102

Open cjpalmer opened 4 years ago

cjpalmer commented 4 years ago

Great module. I started testing it in my environment and found a few issues to clean up and while trying to figure it out, I found that some of the functions were not verbose enough for easy discovery. I started updated functions with verbosity and then additional help (added help to some, extended help on others). I also found the need to update the functionality of Test-ExternalDNSServers because it assumes that outbound ping is allowed. That is not always the case so I added a fallback test that would verify TCP-53 (with the assumption the UDP-53 would work as well) and allowed that to pass the test. I also extended the sample script for creating the scheduled tasks and then updated the build to include that script with the module. I hope you find my additions and updates helpful.

cjpalmer commented 4 years ago

The updates in this pull request address (at least in part) Issue #101 , #96 , and #90