search

comsaint / legco-watch

Parliamentary monitoring for Hong Kong
MIT License
7 stars 3 forks source link

Make Docker Happy #16

Open sorpaas opened 8 years ago

sorpaas commented 8 years ago

This pull request clean up previous Dockerfiles, and use the standard Docker primitives to do the job if possible. Basic supports for parallel Docker/local environments are also added.

  1. Fix rabbitmq server. For now, we directly use the rabbitmq Docker image.
  2. Fix various executable bugs.
  3. Update Fig for Docker Compose.
  4. Instead of building more than five Docker images to bootstrap the development environment, now we only need to build two.
  5. Split settings for Docker and local environment by the INSIDE_DOCKER environment variable.
  6. Update README to reflect the new change.
  7. Use correct text wrap for README.
sorpaas commented 8 years ago

Hi @comsaint, this pull request is now ready for review and merge. :)

sorpaas commented 8 years ago

Hi @comsaint, just resolved the conflict. Please check whether it works with Docker.