comscience15 / PopularPhotosInstagram

0 stars 0 forks source link

[Android Bootcamp] Project week 1- PopularPhotosInstagram #1

Open comscience15 opened 10 years ago

comscience15 commented 10 years ago

I have completed basic and optional requirement but I don't have time to finish Advanced requirement but have something in. I plan to finish it myself to be sure I can do it. /cc @nesquena /cc @thecodepath

codepathreview commented 10 years ago

:+1: Nice job. . A few notes after checking out the code:

One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to continue completing the projects each week with required stories early and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.

Hopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across web and mobile platforms. This assignment also gave us our first introduction to networking, working with APIs and loading remote images. The next assignment will introduce new concept such as accepting user input and navigating between activities but will also reinforce important concepts such as networking, using APIs, handling remote images.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or email us support@thecodepath.com.

Best, PT

P.S. Good to see you properly added the README with features completed and GIFs to your project as described in the submitting assignments guide!

comscience15 commented 10 years ago

Hi PT,

Thank you for your code review. I will update the code following hour suggestion. I agree with need to tweak UI more. My plan is I will work more on each weeks' assignment to complete or add more features on it which could be during or after boot camp. Is it possible to still access in portal and google group still after boot camp done?

Thanks, Nat

On Sep 17, 2014, at 2:19 AM, "CodePath Reviewers" notifications@github.com wrote:

Nice job. . A few notes after checking out the code:

Consider using .gitignore correctly Good layout, proper view naming, usage of sp/dp, margin and relative placement rules Consider initializing your objects only once (listview, adapters, etc) during onCreate() instead of fetchPopularPhotos(); Consider implementing your JSON deserializing logic in your InstagramModel() object. Consider notifying the user with a Toast or any other way in the onFailure() of AsyncHttpClient(); Consider using the ViewHolder pattern in your adapters to better bind your data with the view One of the most important part of these projects is that you add additional features and tweak the UI / UX because that will provide many more learning opportunities. I would encourage you to continue completing the projects each week with required stories early and then spend time adding your own UI elements and experimenting with optional extensions that will improve the user experience.

We have provided a detailed Project 1 Feedback Guide here which covers the most common points we see for this project. Read through the feedback guide point-by-point to determine other ways you could improve your submission. You should consider going back and implementing applicable feedback as well. Keep in mind that one of the most important parts of Android development is learning the correct patterns and conventions.

Hopefully this first project has given you a better sense of working with RelativeLayout which is a very flexible layout system, probably one of the most powerful responsive-first layout systems available across web and mobile platforms. This assignment also gave us our first introduction to networking, working with APIs and loading remote images. The next assignment will introduce new concept such as accepting user input and navigating between activities but will also reinforce important concepts such as networking, using APIs, handling remote images.

If you have any particular questions about the assignment in general or on any of the feedback, feel free to reply here or email us support@thecodepath.com.

Best, PT

P.S. Good to see you properly added the README with features completed and GIFs to your project as described in the submitting assignments guide!

— Reply to this email directly or view it on GitHub.