rdjk instruction is not implemented correctly

[joseemoreira]

Please see the file rdjk.hh (it is not doing a read) an compare to file rdjki.hh (which is doing a read).

Jose

[yl5334]

Hi Jose,

I have realized the problem in my code and changed it to image 1. However, It brings out the problem in image 2. I think it might be the problem with the bit's length. I do not know how to fix it. Could you give me a hint?

Thank you,

Yuqi Lin

On Tue, Apr 2, 2024 at 8:42 PM Jose Moreira @.***> wrote:

Please see the file rdjk.hh (it is not doing a read) an compare to file rdjki.hh (which is doing a read).

Jose

— Reply to this email directly, view it on GitHub https://github.com/comse6998/spring2024/issues/123, or unsubscribe https://github.com/notifications/unsubscribe-auth/BFVMRKQNG3IYSHZPJNMWUJTY3NF7HAVCNFSM6AAAAABFUKRUKWVHI2DSMVQWIX3LMV43ASLTON2WKOZSGIZDCNRXHE4DMNY . You are receiving this because you were assigned.Message ID: @.***>

-- Yuqi Lin he/his M.S. in Electrical Engineering Columbia University, 2024 @.*** | (646)-8086482 linkedin.com/in/yuqi-lin-jeremy/

[joseemoreira]

Hi Yuqi,

I cannot see the images you mention. Do you want to send me an email?

Jose

[yl5334]

Sorry, I attached them to the email first. Now, I attach them on GitHub. Image 1 is my rdjk code, image 2 is the problem.

[joseemoreira]

Your code looks reasonable. I don't think it is this code that if failing the assertion. To be sure, you need to run the program under gdb so that you can get a stack trace for the assertion. Then we will be able to tell what is failing assertion.

[joseemoreira]

I think the problem is that now the semantics of rdjk has changed, and therefore the daxpy code is no longer correct. Before, rdjk was just compying Xk to Xj. If that is what you want to accomplish in daxpy, you now need to use a different instruction.

[yl5334]

I think that might be the problem. I did want to use rdjk to copy Xk to Xj. I will try to fix daxpy using new instruction.

[joseemoreira]

You can use cpkj (Copy (Xk) to Xj in page 40) to copy Xk to Xj. You will have to implement that instruction.

[joseemoreira]

The implementation for it is the old code for rdjk. You need to get the encoding and the operations right.

[yl5334]

OK. I will work out that. Thank you, professor.

[joseemoreira]

You are welcome.