search

comse6998 / spring2024

Repository for COMSE6998 in the Spring 2024 term
2 stars 20 forks source link

Add a no-op pipe_t? #133

Closed tengjiang closed 5 months ago

tengjiang commented 5 months ago

Currently, the pipe() by default returns pipes::FXArith; It seems a little weird to default to pipes::FXArith, and it makes it a little hard to distinguish between a wrong/undefined/no-op operation encoding and pipes::FXArith. So it might be a good idea to include a NOP to pipe_t.

tengjiang commented 5 months ago

If we want to be strict about error checking, we can even add an UNDEFINED type and throw an error every time we encounter one.

joseemoreira commented 5 months ago

I agree with the idea to include a nop to pipe_t. You can go ahead.

tengjiang commented 5 months ago

Hello Professor: I'll create the PR once the basic implementation for FP is merged. This observation actually helped me to solve the infinite loop problem, and I will address it in the corresponding PR.