comse6998 / spring2024

Repository for COMSE6998 in the Spring 2024 term
2 stars 20 forks source link

Latest pull request cause simulation to go into infinite loop #135

Open joseemoreira opened 5 months ago

joseemoreira commented 5 months ago

Hi Lars,

I reviewed your latest pull request. The changes all seem good but the pipe simulation now goes into infinite loop. At least for dcopy. Could you please take a look asap?

Thanks!

joseemoreira commented 5 months ago

Here is the command line that causes the fail:

make clean && clear && make decode run dcopy && ./dcopy && ./run dcopy.tr

joseemoreira commented 5 months ago

Prior to merging your pull request, the pipe simulation stops in cycle 46. You can checkout that version with

git checkout 18bfc7c4c0a1177b7baf3f220629a8a02ae97e3d

lafis002 commented 5 months ago

Hello Professor,

I created another pull request, now with dcopy working again.

However, I noticed that if I comment out the crack function in idjkj it completes, otherwise it runs forever. I will work on it and try to figure out the problem. I also noticed that other programs still run forever.

Best, Lars

On Apr 7, 2024, at 9:08 AM, Jose Moreira @.***> wrote:

Prior to merging your pull request, the pipe simulation stops in cycle 46. You can checkout that version with

git checkout 18bfc7c4c0a1177b7baf3f220629a8a02ae97e3d

— Reply to this email directly, view it on GitHub https://github.com/comse6998/spring2024/issues/135#issuecomment-2041465575, or unsubscribe https://github.com/notifications/unsubscribe-auth/AV7PMPC2PZUOZJHSV5IP5O3Y4FANVAVCNFSM6AAAAABF3KBZW6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGQ3DKNJXGU. You are receiving this because you were assigned.

tengjiang commented 5 months ago

The problem should be fixed by the lastest commit.