comse6998 / spring2024

Repository for COMSE6998 in the Spring 2024 term
2 stars 20 forks source link

Problems in DGEMV_TD #86

Open joseemoreira opened 6 months ago

joseemoreira commented 6 months ago

Andy, you had the following definition:

const double epsilon = pow(1, -9);

This evaluates to 1 (1^(-9) = 1/(1^9) = 1) and is too big for epsilon. I changed the declaration to

const double epsilon = 1e-9;

Also, dscal cannot be used with negative increments. Therefore, I had to change

dscal(n, beta, y, incy);

to

dscal(n, beta, y, abs(incy));

I have uploaded those changes. Please review and let me know if you disagree.

atcheng2 commented 6 months ago

Ah yes, thanks for catching these mistakes!