search

comses / miracle

Repeatable data analysis workflows for computational models
1 stars 3 forks source link

Add basic metadata import functionality and vagrant #2

Closed cpritcha closed 9 years ago

cpritcha commented 9 years ago

This merge has some basic metadata extraction functions for reading file metadata.

landscape-bot commented 9 years ago

Code Health Repository health decreased by 0.61% when pulling 63b99eb on cpritcha:develop into 0cd63ea on comses:master.

cpritcha commented 9 years ago

coveralls does not seem to find my tests. What changes do I need to make to the fabfile?

alee commented 9 years ago

Thanks Calvin!

Some suggestions:

  1. Move dataloader.py to core/metadata.py and remove the dataloader app
  2. Move tests to core/tests/test_metadata.py` - coveralls should find them then
  3. I assume the files in the data directory are just for the tests? If so, let's put them in tests/data - you should be able to refer to them via relative paths (or you can construct an absolute path using settings.BASE_DIR if needed)
  4. Replace print usage with the logging module
  5. Finally, consider squashing the commits into a cohesive whole afterwards: http://blog.steveklabnik.com/posts/2012-11-08-how-to-squash-commits-in-a-github-pull-request
landscape-bot commented 9 years ago

Code Health Repository health decreased by 0.84% when pulling 78cbbb9 on cpritcha:develop into 0cd63ea on comses:master.

landscape-bot commented 9 years ago

Code Health Repository health decreased by 0.82% when pulling 0d9df23 on cpritcha:develop into 0cd63ea on comses:master.

alee commented 9 years ago

Hi Calvin, sorry for the extra work but could you please rebase this pull request against the latest master?

https://github.com/edx/edx-platform/wiki/How-to-Rebase-a-Pull-Request

cpritcha commented 9 years ago

Sure. I'll do that and then merge in the changes.