Open alee opened 8 years ago
cpritcha
commented
8 years ago When I get rid of the Elm embed in the metadata tab and the include for the elm code deleting analysis outputs still does not update the view. Outputs are also not added once an analysis is completed.
alee
commented
8 years ago Strange. Can you verify if it works on master? I wonder if it is a bug introduced during the merge.
On Tuesday, July 5, 2016, cpritcha notifications@github.com wrote:
When I get rid of the Elm embed in the metadata tab and the include for the elm code deleting analysis outputs still does not update the view. Outputs are also not added once an analysis is completed.
— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/comses/miracle/issues/79#issuecomment-230553702, or mute the thread https://github.com/notifications/unsubscribe/AABYBgFUwy2qmMEGiDAx8F3IHei9IiClks5qSptAgaJpZM4JEqz7 .
Sent from Gmail Mobile
cpritcha
commented
8 years ago On master I cannot get far enough to check that it works right now. See #80. I'm going to try converting the Analysis tab to Elm.
This isn't a huge deal since we'll be completely replacing KO with elm (or react/redux depending on how that experiment works out) but it appears the elm bindings are somehow impacting the way the KO mapping plugin manages its child bindings (analyses + analysis outputs).
The buggy use case for this is running analysis scripts or deleting analysis outputs not updating properly the view. You can see what it should look like on the master branch, and see what is currently happening on the elm branch.
As it stands I won't be deploying the elm branch on production unless this gets fixed, since script running is more central to the project than an improved data group metadata management interface and I don't want to have to refresh the browser constantly during the live demo.