search

comtihon / mongodb-erlang

MongoDB driver for Erlang
Apache License 2.0
342 stars 268 forks source link

API Consistency Question #244

Closed varnerac closed 2 years ago

varnerac commented 3 years ago

The mc_worker_api:connect/1 accepts arguments the r_mode configuration option, among others. However, the mc_worker_api:find_one calls do not honor the setting. They only use the readopts values.

It looks like the r_mode value only affects the deprecated versions of mc_worker_api:find calls.

Should I make a PR to indicate that the r_mode setting on mc_worker_api/connect:1 is deprecated, or is there a better course of action?

comtihon commented 3 years ago

Hi @varnerac , yes looks like it is a part of an old api. you can either deprecate it or delete/migrate to the new one (I'd be very thankful to you, as I don't have time to do it myself currently). Than you!